him411/nss-packages-LiBwrt
1
0
Fork 0
mirror of https://github.com/LiBwrt/nss-packages.git synced 2025-12-16 17:15:09 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

nss-ecm: Improve ECM module configuration handling

Browse Source 
This commit fixes two issues with how ECM module options are configured:

1. `/etc/modules.conf` was modified on every ECM start/restart,
   even when no changes were needed.

2. If any other ECM parameters were set in `/etc/modules.conf` it would
   overwrite them as the entire line was replaced.

The solution extracts configuration logic into a dedicated function that
only modifies what's necessary, properly handling all cases (updating existing
parameters, appending to existing options, or creating new options).

Signed-off-by: Sean Khan <datapronix@protonmail.com>
This commit is contained in:
Sean Khan 2025-04-08 12:53:42 -04:00
parent e4bfbb7986
commit 1bed8dab31
1 changed files with 19 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
qca-nss-ecm/files/qca-nss-ecm.init
View File

@ -92,13 +92,30 @@ enable_bridge_filtering() {
fi
}
set_front_end() {
local get_front_end_mode=${1:-0}
local module_conf=/etc/modules.conf
[ ! -r "$module_conf" ] && touch "$module_conf"
# If "options ecm" exists, modify or append front_end_selection
if grep -q "^options ecm" "$module_conf"; then
if grep -q "front_end_selection=" "$module_conf"; then
sed -i -E "s/(options ecm.*)front_end_selection=[0-9]+/\1front_end_selection=$get_front_end_mode/" "$module_conf"
else
# Append front_end_selection if missing
sed -i -E "s/^(options ecm.*)/\1 front_end_selection=$get_front_end_mode/" "$module_conf"
fi
else
# Add new "options ecm" line
echo "options ecm front_end_selection=$get_front_end_mode" >> "$module_conf"
fi
}
load_ecm() {
[ -d /sys/module/ecm ] || {
local get_front_end_mode
get_front_end_mode="$(get_front_end_mode)"
modinfo ecm | awk '/depends/{gsub(",","\n",$NF);print $NF}' | xargs -r -n 1 modprobe
touch /etc/modules.conf
grep -q "options ecm" /etc/modules.conf || echo "options ecm front_end_selection=$get_front_end_mode" >> /etc/modules.conf
set_front_end $get_front_end_mode
modprobe ecm
echo 1 > /sys/kernel/debug/ecm/ecm_classifier_default/accel_delay_pkts
}