him411/nss-packages-breeze303
1
0
Fork 0
mirror of https://github.com/breeze303/nss-packages.git synced 2025-12-15 16:22:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

nss-ecm: Disable rx-gro-list by default

Browse Source 
New option added to ecm config: `disable_gro_list`

This config option defaults to '1' (AKA disable rx-gro-list)
`rx-gro-list` is enabled by default in mainline OpenWrt, however it
is very bug prone, and causes various issues related to
UDP traffic (i.e DHCP, WireGuard, DNS, etc.)

This option is not explicitly required. If a user sets this to '0', a
warning will be shown in the logs everytime ECM is started.

Signed-off-by: Sean Khan <datapronix@protonmail.com>
This commit is contained in:
Sean Khan 2024-10-05 00:08:10 -04:00
parent b217c08798
commit c746083504
3 changed files with 17 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
qca-nss-ecm/Makefile
View File

@ -1,7 +1,7 @@
include $(TOPDIR)/rules.mk
PKG_NAME:=qca-nss-ecm
PKG_RELEASE:=1
PKG_RELEASE:=2
PKG_SOURCE_URL:=https://git.codelinaro.org/clo/qsdk/oss/lklm/qca-nss-ecm.git
PKG_SOURCE_PROTO:=git

20
qca-nss-ecm/files/disable_offloads.sh
View File

@ -100,16 +100,17 @@ disable_offloads() {
fi
}
disable_gro() {
local interface="$1"
disable_feature() {
local feature="$1"
local interface="$2"
local cmd
# Construct ethtool command line
cmd="-K $interface gro off"
cmd="-K $interface $feature off"
# Try to disable flow control
ethtool $cmd 1> /dev/null 2> /dev/null
log $? "Generic Receive Offload" "$interface"
log $? "Disabling feature: $feature" "($interface)"
}
disable_flow_control() {
@ -180,6 +181,7 @@ disable_offload() {
config_get_bool disable_flow_control general disable_flow_control 0
config_get_bool disable_interrupt_moderation general disable_interrupt_moderation 0
config_get_bool disable_gro general disable_gro 0
config_get_bool disable_gro_list general disable_gro_list 1
[ -z $1 ] && interface=$(echo /sys/class/net/*) || interface=$*
@ -192,7 +194,15 @@ disable_offload() {
fi
if [ "$disable_gro" -eq 1 ]; then
disable_gro "$i"
disable_feature gro "$i"
fi
if [ "$disable_gro_list" -eq 1 ]; then
disable_feature "rx-gro-list" "$i"
else
logger -p user.warn -s "[ethtool] Enabling rx-gro-list (GRO Fraglist) will break UDP related traffic. (e.g. DNS, DHCP)"
logger -p user.warn -s "[ethtool] Leave this feature enabled unless you know what you are doing."
logger -p user.warn -s "[ethtool] Run \`uci set ecm.general.disable_gro_list=1 && uci commit ecm && service qca-nss-ecm restart\`"
fi
if [ "$disable_offloads" -eq 1 ]; then

1
qca-nss-ecm/files/qca-nss-ecm.uci
View File

@ -7,3 +7,4 @@ config ecm 'general'
option disable_flow_control '0'
option disable_interrupt_moderation '0'
option disable_gro '0'
option disable_gro_list '1'