From f9ca66a002bebbd950572b28706940b0185d1e34 Mon Sep 17 00:00:00 2001 From: Sean Khan Date: Sun, 2 Jun 2024 19:42:51 -0400 Subject: [PATCH] qca-nss: mark nss-cfi and nss-crypto as broken Because of the way these modules will hook into the kernel certain applications that use devcrypto will try to offload to it. This just kernel panics and user confusion. These modules are broken on IPQ807x and there has been no work upstream to fix it in over 3 years. Luckily these modules aren't required to get offloading for over 95% of use cases (mostly just affects IPSec/OpenVPN). Rather than removing, I'm disabling these modules from showing up in default build options when "@BROKEN" isn't explicitly enabled. Signed-off-by: Sean Khan --- qca-nss-cfi/Makefile | 4 ++-- qca-nss-crypto/Makefile | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/qca-nss-cfi/Makefile b/qca-nss-cfi/Makefile index 232c48c..89a57e4 100644 --- a/qca-nss-cfi/Makefile +++ b/qca-nss-cfi/Makefile @@ -1,7 +1,7 @@ include $(TOPDIR)/rules.mk PKG_NAME:=qca-nss-cfi -PKG_RELEASE:=1 +PKG_RELEASE:=2 PKG_SOURCE_URL:=https://git.codelinaro.org/clo/qsdk/oss/lklm/nss-cfi.git PKG_SOURCE_PROTO:=git @@ -31,7 +31,7 @@ define KernelPackage/qca-nss-cfi-cryptoapi SECTION:=kernel CATEGORY:=Kernel modules SUBMENU:=Cryptographic API modules - DEPENDS:=@TARGET_qualcommax +kmod-qca-nss-crypto +kmod-crypto-authenc + DEPENDS:=@TARGET_qualcommax +kmod-qca-nss-crypto +kmod-crypto-authenc @BROKEN TITLE:=Kernel driver for NSS cfi FILES:=$(PKG_BUILD_DIR)/$(CFI_CRYPTOAPI_DIR)/qca-nss-cfi-cryptoapi.ko AUTOLOAD:=$(call AutoLoad,59,qca-nss-cfi-cryptoapi) diff --git a/qca-nss-crypto/Makefile b/qca-nss-crypto/Makefile index de757fd..392fecb 100644 --- a/qca-nss-crypto/Makefile +++ b/qca-nss-crypto/Makefile @@ -1,7 +1,7 @@ include $(TOPDIR)/rules.mk PKG_NAME:=qca-nss-crypto -PKG_RELEASE:=1 +PKG_RELEASE:=2 PKG_SOURCE_URL:=https://git.codelinaro.org/clo/qsdk/oss/lklm/nss-crypto.git PKG_SOURCE_PROTO:=git @@ -28,7 +28,7 @@ define KernelPackage/qca-nss-crypto SECTION:=kernel CATEGORY:=Kernel modules SUBMENU:=Cryptographic API modules - DEPENDS:=@TARGET_qualcommax +kmod-qca-nss-drv +@NSS_DRV_CRYPTO_ENABLE + DEPENDS:=@TARGET_qualcommax +kmod-qca-nss-drv +@NSS_DRV_CRYPTO_ENABLE @BROKEN TITLE:=Kernel driver for NSS crypto driver FILES:=$(PKG_BUILD_DIR)/$(NSS_CRYPTO_DIR)/src/qca-nss-crypto.ko \ $(PKG_BUILD_DIR)/$(NSS_CRYPTO_DIR)/tool/qca-nss-crypto-tool.ko