him411/nss-packages-qosmio
1
0
Fork 0
mirror of https://github.com/qosmio/nss-packages.git synced 2025-12-18 17:21:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

wwan: Apply shellcheck fixes and add overrides

Browse Source 
Signed-off-by: Sean Khan <datapronix@protonmail.com>
This commit is contained in:
Sean Khan 2025-07-09 21:59:30 -04:00
parent cb16855b9a
commit a688db7c58
1 changed files with 14 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
wwan/utils/quectel-cm/files/quectel.sh
View File

@ -1,4 +1,5 @@
#!/bin/sh #!/bin/sh
# shellcheck shell=busybox disable=3043,2166,3037,3036
[ -n "$INCLUDE_ONLY" ] || { [ -n "$INCLUDE_ONLY" ] || {
. /lib/functions.sh . /lib/functions.sh
@ -32,13 +33,15 @@ proto_quectel_init_config() {
proto_quectel_setup() { proto_quectel_setup() {
local interface="$1" local interface="$1"
local device apn apnv6 auth username password pincode delay pdptype pdnindex pdnindexv6 multiplexing cell_lock_4g local device apn apnv6 auth username password pincode delay pdptype pdnindex pdnindexv6 multiplexing
local dhcp dhcpv6 sourcefilter delegate mtu $PROTO_DEFAULT_OPTIONS # shellcheck disable=2034,2086 # allow unused and word splitting
local cell_lock_4g dhcp dhcpv6 sourcefilter delegate mtu $PROTO_DEFAULT_OPTIONS
local ip4table ip6table local ip4table ip6table
local pid zone local zone
json_get_vars device apn apnv6 auth username password pincode delay pdnindex pdnindexv6 multiplexing json_get_vars device apn apnv6 auth username password pincode delay pdnindex pdnindexv6 multiplexing
json_get_vars pdptype dhcp dhcpv6 sourcefilter delegate ip4table json_get_vars pdptype dhcp dhcpv6 sourcefilter delegate ip4table
# shellcheck disable=2086 # allow word splitting
json_get_vars ip6table mtu $PROTO_DEFAULT_OPTIONS json_get_vars ip6table mtu $PROTO_DEFAULT_OPTIONS
echo -ne "AT+CFUN=1\r\n" >/dev/ttyUSB2 echo -ne "AT+CFUN=1\r\n" >/dev/ttyUSB2
@ -54,8 +57,9 @@ proto_quectel_setup() {
while json_is_a ${idx} string; do while json_is_a ${idx} string; do
json_get_var cell_lock $idx json_get_var cell_lock $idx
pci=$(echo $cell_lock | cut -d',' -f1) # shellcheck disable=2154 # cell_lock is assined and used
earfcn=$(echo $cell_lock | cut -d',' -f2) pci=$(echo "$cell_lock" | cut -d',' -f1)
earfcn=$(echo "$cell_lock" | cut -d',' -f2)
cell_ids="$cell_ids,$earfcn,$pci" cell_ids="$cell_ids,$earfcn,$pci"
idx=$((idx + 1)) idx=$((idx + 1))
done done
@ -109,13 +113,13 @@ proto_quectel_setup() {
[ -n "$pdnindexv6" ] || pdnindexv6="2" [ -n "$pdnindexv6" ] || pdnindexv6="2"
if [ -n "$ipv4opt" ]; then if [ -n "$ipv4opt" ]; then
quectel-cm -i "$ifname" $ipv4opt -n $pdnindex -m 1 ${pincode:+-p $pincode} -s "$apn" "$username" "$password" "$auth" & quectel-cm -i "$ifname" "$ipv4opt" -n $pdnindex -m 1 ${pincode:+-p $pincode} -s "$apn" "$username" "$password" "$auth" &
fi fi
if [ -n "$ipv6opt" ]; then if [ -n "$ipv6opt" ]; then
quectel-cm -i "$ifname" $ipv6opt -n $pdnindexv6 -m 2 ${pincode:+-p $pincode} -s "$apnv6" "$username" "$password" "$auth" & quectel-cm -i "$ifname" "$ipv6opt" -n $pdnindexv6 -m 2 ${pincode:+-p $pincode} -s "$apnv6" "$username" "$password" "$auth" &
fi fi
else else
quectel-cm -i "$ifname" $ipv4opt $ipv6opt ${pincode:+-p $pincode} -s "$apn" "$username" "$password" "$auth" & quectel-cm -i "$ifname" "$ipv4opt" "$ipv6opt" ${pincode:+-p $pincode} -s "$apn" "$username" "$password" "$auth" &
fi fi
sleep 5 sleep 5
@ -125,7 +129,7 @@ proto_quectel_setup() {
# If $ifname_1 is not a valid device set $ifname4 to base $ifname as fallback # If $ifname_1 is not a valid device set $ifname4 to base $ifname as fallback
# so modems not using RMNET/QMAP data aggregation still set up properly. QMAP # so modems not using RMNET/QMAP data aggregation still set up properly. QMAP
# can be set via qmap_mode=n parameter during qmi_wwan_q module loading. # can be set via qmap_mode=n parameter during qmi_wwan_q module loading.
if [ ifconfig "${ifname}_1" ] &>"/dev/null"; then if ifconfig "${ifname}_1" &>"/dev/null"; then
ifname4="${ifname}_1" ifname4="${ifname}_1"
else else
ifname4="$ifname" ifname4="$ifname"
@ -151,7 +155,7 @@ proto_quectel_setup() {
zone="$(fw3 -q network "$interface" 2>/dev/null)" zone="$(fw3 -q network "$interface" 2>/dev/null)"
if [ "$pdptype" = "ipv6" ] || [ "$pdptype" = "ipv4v6" ]; then if [ "$pdptype" = "ipv6" ] || [ "$pdptype" = "ipv4v6" ]; then
ip -6 addr flush dev $ifname6 ip -6 addr flush dev "$ifname6"
json_init json_init
json_add_string name "${interface}_6" json_add_string name "${interface}_6"